Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use non-nullable .get() lookup instead of .first() #75115

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

asottile-sentry
Copy link
Member

this would always crash on line 263 if it were nullable

@asottile-sentry asottile-sentry requested review from a team July 26, 2024 23:29
@asottile-sentry asottile-sentry requested a review from a team as a code owner July 26, 2024 23:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 26, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (84e405e) to head (181190a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #75115   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files        6755     6755           
  Lines      301462   301462           
  Branches    51861    51861           
=======================================
+ Hits       235445   235453    +8     
+ Misses      59686    59679    -7     
+ Partials     6331     6330    -1     
Files Coverage Δ
.../sentry/api/endpoints/organization_events_trace.py 85.56% <100.00%> (ø)

... and 3 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit 477d4ec into master Jul 29, 2024
51 checks passed
@asottile-sentry asottile-sentry deleted the asottile-get-not-first branch July 29, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants