Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix local reassignment of model class union #74956

Merged
merged 1 commit into from
Jul 25, 2024
+4 −4
Merged

ref: fix local reassignment of model class union #74956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sentry/deletions/defaults/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def get_child_relations(self, instance):
]

# in bulk
for m in (
for m1 in (
Activity,
AlertRuleProjects,
EnvironmentProject,
Expand Down Expand Up @@ -81,7 +81,7 @@ def get_child_relations(self, instance):
DiscoverSavedQueryProject,
IncidentProject,
):
relations.append(ModelRelation(m, {"project_id": instance.id}, BulkModelDeletionTask))
relations.append(ModelRelation(m1, {"project_id": instance.id}, BulkModelDeletionTask))

relations.append(ModelRelation(Monitor, {"project_id": instance.id}))
relations.append(ModelRelation(Group, {"project_id": instance.id}))
Expand All @@ -95,11 +95,11 @@ def get_child_relations(self, instance):

# Release needs to handle deletes after Group is cleaned up as the foreign
# key is protected
for m in (
for m2 in (
ReleaseProject,
ReleaseProjectEnvironment,
EventAttachment,
ProjectDebugFile,
):
relations.append(ModelRelation(m, {"project_id": instance.id}, ModelDeletionTask))
relations.append(ModelRelation(m2, {"project_id": instance.id}, ModelDeletionTask))
return relations
Loading