feat(ui): Update Loader Script UI to accomodate v8 #73836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 224 bytes ⬆️
|
s1gr1d
approved these changes
Jul 8, 2024
lforst
approved these changes
Jul 8, 2024
| { | ||
| es5Warning: | ||
| data.browserSdkVersion !== '8.x' | ||
| ? 'When using Replay, the loader will load the ES6 bundle instead of the ES5 bundle. ' |
There was a problem hiding this comment.
This string could be wrapped in a t()
| { | ||
| es5Warning: | ||
| data.browserSdkVersion !== '8.x' |
There was a problem hiding this comment.
Wondering if we should flip it to === 7.x cause that will be more correct in the future. I am wondering in general when we can remove this warning.
mydea
force-pushed
the
fn/loader-script-settings
branch
from
9d749cb
to
3c87a80
Compare
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 11, 2024
This updates the UI of the loader script settings to accomodate v8. Part of getsentry/sentry-javascript#12187
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the UI of the loader script settings to accomodate v8.
Part of getsentry/sentry-javascript#12187