Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix more typing issues in HC modules #73580

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

asottile-sentry
Copy link
Member

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@asottile-sentry asottile-sentry requested review from a team July 1, 2024 15:58
@asottile-sentry asottile-sentry enabled auto-merge (squash) July 1, 2024 15:58
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (ae2388a) to head (d010f7f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73580       +/-   ##
===========================================
+ Coverage   56.88%   78.03%   +21.15%     
===========================================
  Files        6628     6638       +10     
  Lines      296610   296905      +295     
  Branches    51082    51130       +48     
===========================================
+ Hits       168719   231684    +62965     
+ Misses     123180    58947    -64233     
- Partials     4711     6274     +1563     
Files Coverage Δ
src/sentry/audit_log/services/log/impl.py 93.33% <100.00%> (+32.46%) ⬆️
src/sentry/audit_log/services/log/service.py 90.32% <ø> (+3.22%) ⬆️

... and 1995 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit 6f4485e into master Jul 1, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-more-hc-typing-fixes branch July 1, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants