Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update NestJS onboarding #73577

Merged
merged 2 commits into from
Jul 2, 2024
Merged

feat: Update NestJS onboarding #73577

merged 2 commits into from
Jul 2, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 1, 2024

Updates the NestJS onboarding docs and fixes broken links.

@lforst lforst requested a review from a team as a code owner July 1, 2024 15:26
@lforst lforst requested a review from nicohrubec July 1, 2024 15:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 1, 2024
Copy link
Contributor

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (6560123) to head (4b2c02b).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73577      +/-   ##
==========================================
- Coverage   78.03%   78.03%   -0.01%     
==========================================
  Files        6638     6638              
  Lines      296876   296893      +17     
  Branches    51128    51128              
==========================================
+ Hits       231655   231666      +11     
- Misses      58948    58953       +5     
- Partials     6273     6274       +1     
Files Coverage Δ
static/app/gettingStartedDocs/node/nestjs.tsx 47.36% <ø> (ø)
static/app/utils/gettingStartedDocs/node.ts 56.81% <ø> (-4.41%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more reviews like this ... thank you 🚀

@nicohrubec nicohrubec merged commit d455553 into master Jul 2, 2024
42 checks passed
@nicohrubec nicohrubec deleted the lforst-nesjt branch July 2, 2024 07:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants