Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix some typing in hybrid cloud modules #72635

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

asottile-sentry
Copy link
Member

fixes most errors in these modules when BaseManager becomes typed

fixes most errors in these modules when BaseManager becomes typed
@asottile-sentry asottile-sentry requested review from a team June 12, 2024 18:30
@asottile-sentry asottile-sentry marked this pull request as ready for review June 12, 2024 18:30
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 12, 2024 18:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2024
@@ -79,7 +79,7 @@ def create_from_request(
identifier: int | str,
request: HttpRequest,
integration_id: int | None = None,
) -> Self:
) -> WebhookPayload:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to an annoying variance issue interacting with a microbug in django-stubs it can't inference cls.objects properly here as also being BaseManager[Self]

@asottile-sentry asottile-sentry merged commit 8d255a2 into master Jun 12, 2024
49 checks passed
@asottile-sentry asottile-sentry deleted the asottile-hc-typing-manager-enforced branch June 12, 2024 19:00
Copy link

sentry-io bot commented Jun 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OutboxFlushError: Could not flush shard category=30 (SENTRY_APP_UPDATE) sentry.tasks.drain_outbox_shards_control View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants