feat(custom-views): add custom views get endpoint #71942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mrduncan
reviewed
Jun 3, 2024
MichaelSun48
commented
Jun 3, 2024
MichaelSun48
force-pushed
the
msun/addCustomViewsGETEndpoint
branch
from
6e737b3 to
a4f03f3
Compare
malwilley
reviewed
Jun 12, 2024
malwilley
reviewed
Jun 12, 2024
malwilley
reviewed
Jun 12, 2024
malwilley
reviewed
Jun 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71942 +/- ##
==========================================
+ Coverage 78.05% 78.07% +0.01%
==========================================
Files 6597 6599 +2
Lines 294016 294117 +101
Branches 50716 50728 +12
==========================================
+ Hits 229508 229620 +112
+ Misses 58246 58233 -13
- Partials 6262 6264 +2
|
malwilley
reviewed
Jun 13, 2024
| id: str | ||
| name: str | ||
| query: str | ||
| querySort: SORT_LITERALS |
There was a problem hiding this comment.
Can this not be typed as SortOptions?
There was a problem hiding this comment.
I tried for like an hour to get this to work before just giving up. For some reason, mypy refuses to enforce the type if I set it to SortOptions - I setquerySort of a view instance to "awioef" and mypy thought it was fine.
malwilley
approved these changes
Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint creates the
GETorganizations/<org_id_or_slug>/group-search-views/Endpoint along with some tests. This endpoint will be responsible for fetching a user's custom views within an organization.mergedrun in production, and this branch will need to be rebased upon that happening