Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Remove cache updates when marking a replay as viewed #69232

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 18, 2024

Fixes #69209

@ryan953 ryan953 requested a review from a team as a code owner April 18, 2024 19:02
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Bundle Report

Changes will increase total bundle size by 39.97kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.21MB 39.97kB ⬆️

@ryan953 ryan953 merged commit b6239b6 into master Apr 18, 2024
43 checks passed
@ryan953 ryan953 deleted the ryan953/fix-replay-clip-playback branch April 18, 2024 19:14
@ryan953
Copy link
Member Author

ryan953 commented Apr 19, 2024

ryan953 added a commit that referenced this pull request Apr 29, 2024
This follows #69232 which
removed some optimistic updated that would cause crazy re-rendering.
Instead we'll just invalidate (and re-fetch if needed) the `/viewed-by/`
endpoint data.

This is related to the viewed-by replay project:
getsentry/team-replay#19
#64924
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay Clip Play/Pause Does Not Work as Expected (Scrubber doesn't move)
2 participants