feat(replay): Read the has_viewed field on replay records and reflect that in the list #67951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
changed the title
ryan953
force-pushed
the
ryan953/replay-has_seen
branch
from
b3b6008 to
8ad70a7
Compare
ryan953
commented
Apr 2, 2024
ryan953
commented
Apr 9, 2024
billyvg
reviewed
Apr 10, 2024
Comment on lines
+378
to
+379
| <UserAvatar user={getUserBadgeUser(replay)} size={24} /> | ||
| <SubText> |
There was a problem hiding this comment.
Does this look different than using UserBadge?
There was a problem hiding this comment.
it's looking the same to me:
There was a problem hiding this comment.
i'll followup soon with some stories to differentiate the avatar stuff. There's too many components related to that :(
ryan953
commented
Apr 10, 2024
Bundle ReportChanges will increase total bundle size by 225.42kB ⬆️
|
billyvg
approved these changes
Apr 11, 2024
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
… that in the list (#67951) Depends on backend support for the new `has_viewed` field. Follows the blueprint in https://github.com/getsentry/sentry/blob/master/src/sentry/replays/blueprints/api.md Relates to getsentry/team-replay#19 Relates to #64924 Depends on #68628
ryan953
added a commit
that referenced
this pull request
Apr 15, 2024
… seen (#68743) Depends on #67951 Relates to getsentry/team-replay#19 Relates to #64924
ryan953
added a commit
that referenced
this pull request
Apr 16, 2024
… seen (#68743) Depends on #67951 Relates to getsentry/team-replay#19 Relates to #64924
ryan953
added a commit
that referenced
this pull request
Apr 16, 2024
… seen (#68990) This is a dupe of #68743, but with a feature-flag wrapping it. Depends on #67951 Relates to getsentry/team-replay#19 Relates to #64924
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on backend support for the new
has_viewedfield.Follows the blueprint in https://github.com/getsentry/sentry/blob/master/src/sentry/replays/blueprints/api.md
Relates to https://github.com/getsentry/team-replay/issues/19
Relates to #64924
Depends on #68628