Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser-starfish): cursor persisting when navigating between pages/filters #60378

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

DominikB2014
Copy link
Contributor

Fixes two issues in resource module

  1. The cursor was not being reset when adding filters such as type, blocking status in the main resources page.
  2. When you navigate to another page in the resources table, then click on a resource, that same cursor would be used to fetch the "found in pages" table. To solve this we use the spansCursor query param in the resources page, and pagesCursor query param in the resourceSummary.

@DominikB2014 DominikB2014 requested review from AbhiPrasad and a team November 21, 2023 17:03
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 21, 2023
@DominikB2014 DominikB2014 enabled auto-merge (squash) November 21, 2023 17:19
@DominikB2014 DominikB2014 merged commit e5d4b98 into master Nov 21, 2023
40 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/dont-persist-cursor branch November 21, 2023 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants