Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hybridcloud) Remove limit on project key query used in sdk wizard #60103

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

markstory
Copy link
Member

Limiting these results can create user confusion as they aren't able to find the project/dsn they are interested in. We'll need to revisit this in the future as unbounded API requests will eventually timeout.

Limiting these results can create user confusion as they aren't able to
find the project/dsn they are interested in. We'll need to revisit this
in the future as unbounded API requests will eventually timeout.
@markstory markstory requested review from lforst and Lms24 November 16, 2023 16:19
@markstory markstory requested a review from a team as a code owner November 16, 2023 16:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #60103 (e5e1665) into master (eab0e8b) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60103   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files        5179     5179           
  Lines      227468   227486   +18     
  Branches    38273    38277    +4     
=======================================
+ Hits       183708   183730   +22     
+ Misses      38157    38155    -2     
+ Partials     5603     5601    -2     
Files Coverage Δ
...c/sentry/services/hybrid_cloud/project_key/impl.py 85.71% <ø> (ø)
...entry/services/hybrid_cloud/project_key/service.py 86.66% <ø> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this so quickly!

@markstory markstory merged commit 9025eb4 into master Nov 16, 2023
51 checks passed
@markstory markstory deleted the fix-wizard-limit branch November 16, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants