Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unrevert(feat(eventuser)): Migrate IssuesByTagProcessor away from EventUser #60071

Merged

Conversation

NisanthanNanthakumar
Copy link
Contributor

Objective:

Create the for_tags method in the EventUser dataclass. Migrates get_eventuser_callback to use the dataclass.

Unreverts #59672

@NisanthanNanthakumar NisanthanNanthakumar requested review from a team November 16, 2023 03:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #60071 (4a8ac6d) into master (2927744) will increase coverage by 0.15%.
Report is 141 commits behind head on master.
The diff coverage is 93.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60071      +/-   ##
==========================================
+ Coverage   80.61%   80.77%   +0.15%     
==========================================
  Files        5175     5180       +5     
  Lines      227259   227841     +582     
  Branches    38243    38354     +111     
==========================================
+ Hits       183214   184047     +833     
+ Misses      38464    38195     -269     
- Partials     5581     5599      +18     
Files Coverage Δ
src/sentry/analytics/events/__init__.py 100.00% <100.00%> (ø)
...c/sentry/analytics/events/eventuser_snuba_query.py 100.00% <100.00%> (ø)
src/sentry/data_export/processors/issues_by_tag.py 100.00% <100.00%> (ø)
src/sentry/search/utils.py 84.19% <100.00%> (ø)
src/sentry/utils/eventuser.py 94.28% <92.30%> (+16.65%) ⬆️

... and 135 files with indirect coverage changes

@wedamija wedamija merged commit cc7731f into master Nov 16, 2023
94 checks passed
@wedamija wedamija deleted the 59394-migrate-issuesbytagprocessor-away-from-eventuser-model branch November 16, 2023 18:12
Copy link

sentry-io bot commented Nov 20, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AssertionError: expected call not found. pytest.runtest.protocol tests/sentry/utils/test... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants