ref(backup): Use burst task runner for better tests #59926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/notify-users
branch
from
310d9b2 to
59592cb
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/use-burst-task-runner
branch
from
577d62d to
c87a372
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #59926 +/- ##
==========================================
- Coverage 80.79% 80.79% -0.01%
==========================================
Files 5181 5181
Lines 227825 227831 +6
Branches 38364 38366 +2
==========================================
- Hits 184077 184076 -1
- Misses 38117 38121 +4
- Partials 5631 5634 +3
|
azaslavsky
force-pushed
the
azaslavsky/backup/notify-users
branch
from
59592cb to
95e071a
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/use-burst-task-runner
branch
from
c87a372 to
b711e8d
Compare
hubertdeng123
approved these changes
Nov 16, 2023
azaslavsky
force-pushed
the
azaslavsky/backup/notify-users
branch
from
95e071a to
d3da641
Compare
Instead of using the default task runner, which runs celery tasks at their call sites and causes all sorts of shenanigans with nested transactions, we switch to the "burst" task runner. This allows us to add "max" retry test cases as well, and helped catch a couple of sneaky bugs. Closes getsentry/team-ospo#169 Closes getsentry/team-ospo#203
azaslavsky
force-pushed
the
azaslavsky/backup/use-burst-task-runner
branch
from
b711e8d to
64b56ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the default task runner, which runs celery tasks at their call sites and causes all sorts of shenanigans with nested transactions, we switch to the "burst" task runner. This allows us to add "max" retry test cases as well, and helped catch a couple of sneaky bugs.
Closes getsentry/team-ospo#169
Closes getsentry/team-ospo#203