Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): Relocation succeeded email #59924

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

azaslavsky
Copy link
Contributor

@azaslavsky azaslavsky commented Nov 14, 2023

The last thing we do before marking a Relocation instance as a SUCCESS is send an email to the owner and/or creator of that relocation that it has completed successfully.

Screenshot 2023-11-15 at 15 49 56

Screenshot 2023-11-15 at 15 50 03

Issue: getsentry/team-ospo#203

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 14, 2023
@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-failed-email branch from f3ec862 to 9394c55 Compare November 14, 2023 23:41
@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-succeeded-email branch from 82a253a to 4eff67e Compare November 14, 2023 23:41
@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-failed-email branch from 9394c55 to 57c2093 Compare November 15, 2023 23:52
@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-succeeded-email branch from 4eff67e to 7c922e3 Compare November 15, 2023 23:53
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #59924 (fdb0b05) into master (5d71c86) will increase coverage by 0.00%.
The diff coverage is 78.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #59924   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files        5181     5181           
  Lines      227723   227733   +10     
  Branches    38338    38339    +1     
=======================================
+ Hits       183955   183965   +10     
+ Misses      38148    38146    -2     
- Partials     5620     5622    +2     
Files Coverage Δ
src/sentry/utils/relocation.py 98.43% <100.00%> (+0.01%) ⬆️
src/sentry/web/debug_urls.py 100.00% <ø> (ø)
src/sentry/web/frontend/debug/mail.py 85.42% <66.66%> (-0.17%) ⬇️
src/sentry/tasks/relocation.py 85.43% <77.77%> (-0.04%) ⬇️

... and 5 files with indirect coverage changes

@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-failed-email branch from 57c2093 to cf5ee14 Compare November 16, 2023 19:10
Base automatically changed from azaslabsky/backup/relocation-failed-email to master November 16, 2023 19:44
The last thing we do before marking a `Relocation` instance as a
`SUCCESS` is send an email to the owner and/or creator of that
relocation that it has completed successfully.

Issue: getsentry/team-ospo#203
@azaslavsky azaslavsky force-pushed the azaslabsky/backup/relocation-succeeded-email branch from 7c922e3 to fdb0b05 Compare November 16, 2023 19:47
@azaslavsky azaslavsky marked this pull request as ready for review November 16, 2023 20:37
@azaslavsky azaslavsky requested a review from a team as a code owner November 16, 2023 20:37
@azaslavsky azaslavsky merged commit ac00924 into master Nov 16, 2023
48 of 49 checks passed
@azaslavsky azaslavsky deleted the azaslabsky/backup/relocation-succeeded-email branch November 16, 2023 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants