feat(backup): Send relocation started email #59922
Merged
+112
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/post-processing
branch
from
fdf9740 to
0430dbe
Compare
azaslavsky
force-pushed
the
azaslabsky/backup/relocation-started-email
branch
from
b243739 to
bebb04e
Compare
| @@ -53,6 +53,9 @@ | |||
| <option value="mail/sentry-app-notify-disable/">Sentry App Notify Disable</option> | |||
| <option value="mail/join-request/">Join Request</option> | |||
| </optgroup> | |||
| <optgroup label="Relocation"> | |||
| <option value="mail/relocation-started/">Relocation Started</option> | |||
There was a problem hiding this comment.
should we move Relocate Account here if this is now a new group?
|
|
||
| {% block main %} | ||
| <h3>Relocation Accepted</h3> | ||
| <p>Your relocation (id: <i>{{ uuid }}</i>) request has been accepted. You requested that the following organizations be migrating to sentry.io:</p> |
There was a problem hiding this comment.
It feels a bit weird to have the uuid in parentheses here, would it be better to have that in smaller text underneath the header Relocation Accepted? Not a designer though, so maybe I don't know what I'm talking about
There was a problem hiding this comment.
Done.
I've updated the images attached to the PR to reflect this.
azaslavsky
force-pushed
the
azaslavsky/backup/post-processing
branch
from
0430dbe to
69be331
Compare
azaslavsky
force-pushed
the
azaslabsky/backup/relocation-started-email
branch
from
bebb04e to
ec317a8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #59922 +/- ##
==========================================
- Coverage 80.78% 80.78% -0.01%
==========================================
Files 5181 5181
Lines 227655 227673 +18
Branches 38320 38323 +3
==========================================
+ Hits 183910 183924 +14
- Misses 38134 38138 +4
Partials 5611 5611
|
hubertdeng123
approved these changes
Nov 16, 2023
azaslavsky
force-pushed
the
azaslavsky/backup/post-processing
branch
2 times, most recently
from
7444b21 to
2e438da
Compare
Once we have decent confidence that a relocation is not obviously invalid, we send the owner (and creator, if they are different people) an email indicating that their relocation has started. Issue: getsentry/team-ospo#203
azaslavsky
force-pushed
the
azaslabsky/backup/relocation-started-email
branch
from
ec317a8 to
2145474
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have decent confidence that a relocation is not obviously invalid, we send the owner (and creator, if they are different people) an email indicating that their relocation has started.
Issue: getsentry/team-ospo#203