ref(backup): Refine dangling model resolution #57335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/refine_dangling
branch
from
f871c13 to
789f575
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/unique_coverage
branch
from
98ccd66 to
b81b8ec
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/refine_dangling
branch
from
789f575 to
b494cf3
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/unique_coverage
branch
from
b81b8ec to
93ca40d
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/refine_dangling
branch
from
b494cf3 to
9f9ce36
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/unique_coverage
branch
from
93ca40d to
7650f21
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/refine_dangling
branch
from
9f9ce36 to
288e0fd
Compare
Certain models that do not have unambiguous relationship to any RelocationScope root model (ex: Organization, User, etc) are termed "dangling", because filtering them down is done by simply moving up the model dependency tree from the root to the leaves - we have to double back and look at these "dangling" innner leaves instead. See https://tinyurl.com/27z4x6tk for more info; the `SnubaQuery`, `TimeSeriesSnapshot`, and `Email` models are all dangling in this manner. This PR changes the dangling resolution logic a bit: all `Excluded` relocation scope models are no longer considered dangling. Additionally, a few models that didn't quite get over the hump for "dangling" resolution during status analysis, but are obviously so, are marked as such. Issue: getsentry/team-ospo#203
azaslavsky
force-pushed
the
azaslavsky/backup/unique_coverage
branch
from
7650f21 to
63df56c
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/refine_dangling
branch
from
288e0fd to
11fcf1d
Compare
chadwhitacre
approved these changes
Oct 10, 2023
azaslavsky
merged this pull request
into
azaslavsky/backup/unique_coverage
43 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain models that do not have an unambiguous relationship to any RelocationScope root model (ex: Organization, User, etc) are termed "dangling", because filtering them other models is done by simply moving up the model dependency tree from the root to the leaves, for "dangling" models we have to double back and look at these "dangling" innner leaves instead. See https://tinyurl.com/27z4x6tk for more info; the
SnubaQuery,TimeSeriesSnapshot, andEmailmodels are all dangling in this manner.This PR changes the dangling resolution logic a bit: all
Excludedrelocation scope models are no longer considered dangling. Additionally, a few models that didn't quite get over the hump for "dangling" resolution during status analysis, but are obviously so, are marked as such.Issue: getsentry/team-ospo#203