feat(backup): Generate new OrgAuthToken on input #56022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #56022 +/- ##
==========================================
- Coverage 80.00% 78.61% -1.39%
==========================================
Files 5066 5065 -1
Lines 217964 217411 -553
Branches 36889 36781 -108
==========================================
- Hits 174376 170918 -3458
- Misses 38240 40980 +2740
- Partials 5348 5513 +165
|
Base automatically changed from
azaslavsky/backup/rename_test_release
to
master
September 11, 2023 19:43
azaslavsky
force-pushed
the
azaslavsky/backup/org_auth_token
branch
from
dc76ccf to
435bdf3
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/org_auth_token
branch
from
435bdf3 to
4577593
Compare
Instead of making a duplicate of the existing token when we copy an org across regions, which could cause problems for downstream code that relies on this uniqueness, we simply make a new instance of the token value. This will break operations that rely on this token as users move from the old org to the new one, but this an okay price to pay to preserve uniqueness. Issue: getsentry/team-ospo#193
azaslavsky
force-pushed
the
azaslavsky/backup/org_auth_token
branch
from
4577593 to
dfb047a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making a duplicate of the existing token when we copy an org across regions, which could cause problems for downstream code that relies on this uniqueness, we simply make a new instance of the token value. This will break operations that rely on this token as users move from the old org to the new one, but this an okay price to pay to preserve uniqueness.
Issue: getsentry/team-ospo#193