fix(backup): UserEmail handling #55433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
2 times, most recently
from
556eb2f to
0108471
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/useremail_validation
branch
from
1dbdd42 to
1b328fc
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/useremail_validation
branch
from
1b328fc to
c4a3284
Compare
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
from
0108471 to
5c32990
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
from
5c32990 to
db3c179
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/useremail_validation
branch
from
c4a3284 to
298de54
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
from
db3c179 to
1dec885
Compare
azaslavsky
removed
the
Scope: Frontend
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
from
1dec885 to
86a3356
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/useremail_validation
branch
from
298de54 to
12263f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #55433 +/- ##
==========================================
- Coverage 80.14% 78.43% -1.71%
==========================================
Files 5045 5045
Lines 216004 216016 +12
Branches 36542 36546 +4
==========================================
- Hits 173108 169442 -3666
- Misses 37612 41235 +3623
- Partials 5284 5339 +55
|
azaslavsky
force-pushed
the
azaslavsky/backup/model_save
branch
from
86a3356 to
8bc676b
Compare
The previous code assumed UserEmail collisions are possible. It is now refactored to treat them all as unique, and always reset them from their imported state for all `ImportScope`s except `Global`. Issue: getsentry/team-ospo#181
azaslavsky
force-pushed
the
azaslavsky/backup/useremail_validation
branch
from
12263f3 to
2579869
Compare
EricHasegawa
pushed a commit
that referenced
this pull request
Sep 6, 2023
The previous code assumed UserEmail collisions are possible. It is now refactored to treat them all as unique, and always reset them from their imported state for all `ImportScope`s except `Global`. Issue: getsentry/team-ospo#181
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code assumed UserEmail collisions are possible. It is now refactored to treat them all as unique, and always reset them from their imported state for all
ImportScopes exceptGlobal.Issue: getsentry/team-ospo#181