feat(ui): Add copy link + copy markdown dropdown to short ID #53825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
Jul 29, 2023
| > | ||
| <StyledShortId shortId={group.shortId} /> | ||
| </Tooltip> | ||
| <DropdownMenu |
There was a problem hiding this comment.
This menu is causing some sizing problems that I need to look into before merging this.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-ui-add-copy-link-copy-markdown-dropdown-to-short-id
branch
from
2fb206e to
0492ca0
Compare
|
How would someone discover this feature if the chevron is hidden by default? |
Looks like This  When not hovered there's nothing 
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-ui-add-copy-link-copy-markdown-dropdown-to-short-id
branch
from
0492ca0 to
601cf95
Compare
I would consider this a bit of a power user feature. We don't need to go out of our way to make every available action in your face, in this case, we actually already had an affordance on the short ID that when you click it it would auto-select to make it easier to copy. Now when you hover and notice the small chevron, the user will get a little sense of delight of "nice this is exactly what I wanted" |
scttcper
approved these changes
Jul 31, 2023
evanpurkhiser
deleted the
evanpurkhiser/feat-ui-add-copy-link-copy-markdown-dropdown-to-short-id
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like This
When not hovered there's nothing