test(backup): Ensure coverage of all exportable models #53295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/flake8
branch
from
073e863 to
25906ad
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/test_coverage
branch
from
5c09cc8 to
1e07fda
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53295 +/- ##
==========================================
- Coverage 79.55% 79.52% -0.03%
==========================================
Files 4942 4939 -3
Lines 208542 208076 -466
Branches 35525 35479 -46
==========================================
- Hits 165903 165478 -425
+ Misses 37586 37560 -26
+ Partials 5053 5038 -15 |
azaslavsky
force-pushed
the
azaslavsky/backup/test_coverage
branch
from
1e07fda to
6a518ba
Compare
azaslavsky
requested review from
hubertdeng123
and removed request for
chadwhitacre
azaslavsky
force-pushed
the
azaslavsky/backup/test_coverage
branch
from
efdb281 to
dc8dfc1
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/test_coverage
branch
from
dc8dfc1 to
162371c
Compare
chadwhitacre
approved these changes
Jul 21, 2023
hubertdeng123
approved these changes
Jul 21, 2023
The basic idea here is to include a test that finds all non-abstract descendants of our `BaseModel`, filter down to just the exportable ones (ie, those that set `__include_in_export__ = True`), and then ensure that each of them is included in at least one of the tests seen in `test_models.py`. This is done by introducing a new `mark` wrapper class which ingests all of the "target" models used by the `@targets` test decorator at init time, allowing us to create an exhaustive list of all types passed to `@targets`. Issue: getsentry/team-ospo#156
azaslavsky
force-pushed
the
azaslavsky/backup/test_coverage
branch
from
162371c to
c057e81
Compare
armenzg
pushed a commit
that referenced
this pull request
Jul 24, 2023
The basic idea here is to include a test that finds all non-abstract descendants of our `BaseModel`, filter down to just the exportable ones (ie, those that set `__include_in_export__ = True`), and then ensure that each of them is included in at least one of the tests seen in `test_models.py`. This is done by introducing a new `mark` wrapper class which ingests all of the "target" models used by the `@targets` test decorator at init time, allowing us to create an exhaustive list of all types passed to `@targets`. Issue: getsentry/team-ospo#156
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea here is to include a test that finds all non-abstract descendants of our
BaseModel, filter down to just the exportable ones (ie, those that set__include_in_export__ = True), and then ensure that each of them is included in at least one of the tests seen intest_models.py. This is done by introducing a newmarkwrapper class which ingests all of the "target" models used by the@targetstest decorator at init time, allowing us to create an exhaustive list of all types passed to@targets.Issue: getsentry/team-ospo#156