test(backup): Ensure expected models are in output #52690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
3524e25 to
3a1a138
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
343e98c to
53f568c
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
3a1a138 to
7d04736
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
53f568c to
2e6e042
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
c697e1a to
5774faf
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
5774faf to
e45420c
Compare
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
7d04736 to
fcaea59
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
e45420c to
faa54f8
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
fcaea59 to
d9f8423
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
faa54f8 to
2251d81
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
d9f8423 to
9d825bf
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
2251d81 to
bcdff0c
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
9d825bf to
31afbf3
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
bcdff0c to
d72d146
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
2 times, most recently
from
e91cdae to
17479e4
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
d72d146 to
ffa3026
Compare
azaslavsky
removed
Scope: Frontend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52690 +/- ##
==========================================
+ Coverage 77.00% 79.37% +2.36%
==========================================
Files 4934 4934
Lines 207215 207215
Branches 35403 35403
==========================================
+ Hits 159573 164478 +4905
+ Misses 42482 37706 -4776
+ Partials 5160 5031 -129 |
We add a new decorator, `@targets_models`, for the `.../backup/test_models.py` test suite. The goal is two-fold: for each individual test, the decorator provides a concise way to express which models must be included in the output, lest we end up with a test that passes the equality check, but only because it excluded our target model(s) altogether. The second goal is to make the set of models being exercised in the `ModelBackupTests` class easily visible to static analysis tools like flake8, so that we may later create a check ensuring that all `__include_in_export__ = True` marked models in this repository are included in this test suite. Issue: getsentry/team-ospo#156 Issue: getsentry/team-ospo#160
azaslavsky
force-pushed
the
azaslavsky/backup/target_models_decorator
branch
from
ffa3026 to
12b1476
Compare
chadwhitacre
approved these changes
Jul 14, 2023
armenzg
pushed a commit
that referenced
this pull request
Jul 17, 2023
We add a new decorator, `@targets_models`, for the `.../backup/test_models.py` test suite. The goal is two-fold: for each individual test, the decorator provides a concise way to express which models must be included in the output, lest we end up with a test that passes the equality check, but only because it excluded our target model(s) altogether. The second goal is to make the set of models being exercised in the `ModelBackupTests` class easily visible to static analysis tools like flake8, so that we may later create a check ensuring that all `__include_in_export__ = True` marked models in this repository are included in this test suite. Issue: getsentry/team-ospo#156 Issue: getsentry/team-ospo#160
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new decorator,
@targets_models, for the.../backup/test_models.pytest suite. The goal is two-fold: for each individual test, the decorator provides a concise way to express which models must be included in the output, lest we end up with a test that passes the equality check, but only because it excluded our target model(s) altogether. The second goal is to make the set of models being exercised in theModelBackupTestsclass easily visible to static analysis tools like flake8, so that we may later create a check ensuring that all__include_in_export__ = Truemarked models in this repository are included in this test suite.Issue: getsentry/team-ospo#156
Issue: getsentry/team-ospo#160