feat(backup): Support alert rules #52669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
642312a to
4500d9b
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
c3b8bdd to
3524e25
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
4500d9b to
3cd04cf
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
3524e25 to
3a1a138
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
3cd04cf to
ba423f0
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
3a1a138 to
7d04736
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
ba423f0 to
bc07545
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
7d04736 to
fcaea59
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
bc07545 to
864b9d6
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
fcaea59 to
d9f8423
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
d9f8423 to
9d825bf
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/comparators
branch
from
de8fb06 to
586a34b
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
9d825bf to
31afbf3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52669 +/- ##
==========================================
- Coverage 79.37% 79.37% -0.01%
==========================================
Files 4934 4934
Lines 207215 207215
Branches 35403 35403
==========================================
- Hits 164481 164480 -1
- Misses 37704 37706 +2
+ Partials 5030 5029 -1
|
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
31afbf3 to
e91cdae
Compare
Adds a number of tests for exportable AlertRule* Sentry models, which necessitates testing for SnubaQuery* and QuerySubscription models as well, as these are included in AlertRule instances by default. Issue: getsentry/team-ospo#156
azaslavsky
force-pushed
the
azaslavsky/backup/support_alert_rules
branch
from
e91cdae to
17479e4
Compare
armenzg
pushed a commit
that referenced
this pull request
Jul 17, 2023
Adds a number of tests for exportable AlertRule* Sentry models, which necessitates testing for SnubaQuery* and QuerySubscription models as well, as these are included in AlertRule instances by default. Issue: getsentry/team-ospo#156
kneeyo1
added a commit
that referenced
this pull request
Jul 19, 2023
WIP of tests for exportable models. related prs are #52669 --------- Co-authored-by: Alex Zaslavsky <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a number of tests for exportable AlertRule* Sentry models, which necessitates testing for SnubaQuery* and QuerySubscription models as well, as these are included in AlertRule instances by default.
Issue: getsentry/team-ospo#156