fix(threads): Use selected thread name in thread-selector if available #48689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
13 tasks
shruthilayaj
approved these changes
May 8, 2023
static/app/components/events/interfaces/threads/threadSelector/selectedOption.tsx
Outdated
Show resolved
Hide resolved
static/app/components/events/interfaces/threads/threadSelector/selectedOption.tsx
Outdated
Show resolved
Hide resolved
…/selectedOption.tsx Co-authored-by: Shruthi <[email protected]>
…/selectedOption.tsx Co-authored-by: Shruthi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread name usually makes more sense than the label, when available (checked with other SDK folks), because it has to be unique whereas the label is not guaranteed to be unique. Also, the label can be quite long, depending on the stackframe type (e.g. JNI on Android), which makes it barely readable.
If the name is not available, the label is still used as a fallback.
Before
After