Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering Unreal events by their crash_type #44021

Merged
merged 20 commits into from
Feb 7, 2023

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 2, 2023

Resolves #38550
Frontend: #44095

Unreal events have crash_type as part of their Unreal context that originates from ECrashTypeContext.

enum ECrashContextType
{
    Crash,
    Assert,
    Ensure,
    Stall,
    GPUCrash,
    Hang,
    OutOfMemory,
    AbnormalShutdown,
    Max,
}

image

I'd like to make it possible to filter by this context.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 19.56 KB (-0.02% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css 32.99 KB (0%)

@bitsandfoxes bitsandfoxes merged commit c4f42b3 into master Feb 7, 2023
@bitsandfoxes bitsandfoxes deleted the feat/unreal-crashtype branch February 7, 2023 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnrealEngine: Add CrashType as a tag to allow filtering
3 participants