Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Push docker images to dockerhub from github action for e2e tests #42467

Merged
merged 6 commits into from
Dec 21, 2022
Merged

ci: Push docker images to dockerhub from github action for e2e tests #42467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e65fa9
ci: Push docker images to dockerhub from github action for e2e tests
emmatyping Dec 19, 2022
08fad25
Fix typo to trigger CI
emmatyping Dec 19, 2022
3671db1
Update e2e action SHA and include short SHA/full SHA step
emmatyping Dec 20, 2022
52a9cce
Merge branch 'master' into ethanhs/push-images-dockerhub
emmatyping Dec 20, 2022
b382263
Merge commit calculation into action
emmatyping Dec 21, 2022
eed01d4
Merge branch 'master' into ethanhs/push-images-dockerhub
emmatyping Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions .github/workflows/self-hosted-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,29 +28,11 @@ jobs:
with:
token: ${{ github.token }}
filters: .github/file-filters.yml

- name: Pull the test image
if: steps.changes.outputs.backend_all == 'true'
id: image_pull
env:
SENTRY_TEST_IMAGE: us.gcr.io/sentryio/sentry:${{ github.event.pull_request.head.sha || github.sha }}
run: |
echo "We poll for the Sentry Docker image that the GCB build produces until it succeeds or this job times out."
if [[ -z "$SENTRY_TEST_IMAGE" ]]; then
echo "The SENTRY_TEST_IMAGE needs to be set" 1>&2
exit 1
fi
echo "Polling for $SENTRY_TEST_IMAGE"
until docker pull "$SENTRY_TEST_IMAGE" 2>/dev/null; do
sleep 10
done
echo "sentry-test-image-name=$SENTRY_TEST_IMAGE" >> "$GITHUB_OUTPUT"

# TODO: push the image here
- name: Run Sentry self-hosted e2e CI
if: steps.changes.outputs.backend_all == 'true'
uses: getsentry/action-self-hosted-e2e-tests@fa5b8240848f0e645ac2918c530e60ec8f50e4b8
uses: getsentry/action-self-hosted-e2e-tests@697a3ca95a72f93e3a1ebdb8f967be38d1f029f6
with:
project_name: sentry
local_image: ${{ steps.image_pull.outputs.sentry-test-image-name }}
docker_repo: docker.io/getsentry/sentry
image_url: us.gcr.io/sentryio/sentry:${{ github.event.pull_request.head.sha || github.sha }}
docker_repo: getsentry/sentry
docker_password: ${{ secrets.DOCKER_HUB_RW_TOKEN }}
2 changes: 1 addition & 1 deletion src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,7 @@ def build_cdc_postgres_init_db_volume(settings):
SUDO_URL = "sentry-sudo"

# Endpoint to https://github.com/getsentry/sentry-release-registry, used for
# alerting the user on outdated SDKs.
# alerting the user of outdated SDKs.
SENTRY_RELEASE_REGISTRY_BASEURL = None

# Hardcoded SDK versions for SDKs that do not have an entry in the release
Expand Down