Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discover): Displays custom units in custom perf metrics sidebar in event detail pagge #39543

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Oct 3, 2022

When a custom performance metric has a custom unit supplied, render that unit in the custom performance metrics side bar in the event details pages
image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 20.33 KB (-0.02% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css 33.05 KB (0%)

@edwardgou-sentry edwardgou-sentry requested a review from a team October 3, 2022 14:24
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review October 3, 2022 14:24
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner October 3, 2022 14:24
@edwardgou-sentry edwardgou-sentry merged commit 0b40da0 into master Oct 3, 2022
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/event-details-page-custom-perf-metrics-custom-unit branch October 3, 2022 19:30
ryan953 pushed a commit that referenced this pull request Oct 3, 2022
…n event detail pagge (#39543)

When a custom performance metric has a custom unit supplied, render that
unit in the custom performance metrics side bar in the event details
pages
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants