Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(js): Upgrade JS SDK to 6.18.1-beta.0 #32181

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

getsentry/sentry-javascript#4531

This will also fix the console array problem.

@AbhiPrasad AbhiPrasad requested a review from k-fish March 1, 2022 20:32
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner March 1, 2022 20:32
@evanpurkhiser
Copy link
Member

oh yes yes

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 1, 2022 20:36
@AbhiPrasad
Copy link
Member Author

Sorry this took a while!

We had some stuff (getsentry/sentry-javascript#4619, getsentry/sentry-javascript#4531 (comment)) getting in the way :P

@@ -3,6 +3,7 @@
// eslint-disable-next-line
import * as fs from 'fs';
import * as Sentry from '@sentry/node';
import '@sentry/tracing';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the linter makes you put this in a group above these other things no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because it is under .github/workflows/scripts/monitor-typescript.ts? I can move it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah maybe linter isn't checking this?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 54.42 KB (+0.02% 🔺)
src/sentry/static/sentry/dist/entrypoints/sentry.css 69.9 KB (0%)

@AbhiPrasad AbhiPrasad merged commit f771af6 into master Mar 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-6.18.1-beta.0 branch March 1, 2022 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants