Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump simplejson #20162

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Aug 10, 2020

We're bumping so that simplejson is on a version that is tested against 3.6, our target py3 version.

The migration from 3.8.2 -> 3.11 is trivial, here is a summarized changelog, not including meta changes in the package:

Version 3.11.0 released 2017-06-18

Version 3.10.0 released 2016-10-28

Version 3.9.0 released 2016-10-21

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner August 10, 2020 20:15
@evanpurkhiser evanpurkhiser requested a review from a team August 10, 2020 20:15
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should bump this in getsentry at the same time

@evanpurkhiser evanpurkhiser merged commit 2940e09 into master Aug 10, 2020
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/builddeps-bump-simplejson branch August 10, 2020 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants