build: Allow people to use volta instead of notion #13200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitsuhiko volta-cli/volta#432 will take a while, meanwhile I don't see the big deal in duplicating this. |
|
We also need to add volta instead of notion to the makefile |
|
@mitsuhiko can you re-review? Just wanna get this merged instead of having to downgrade to notion again :D |
mitsuhiko
approved these changes
May 15, 2019
billyvg
pushed a commit
that referenced
this pull request
May 15, 2019
* build: Allow people to use volta instead of notion * fix: Update Makefile as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just duplicate this for now, and remove
toolchainlater