Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big number says "Cannot sort by field that isn't selected" #83328

Closed
narsaynorath opened this issue Jan 13, 2025 · 1 comment · Fixed by #83376
Closed

Big number says "Cannot sort by field that isn't selected" #83328

narsaynorath opened this issue Jan 13, 2025 · 1 comment · Fixed by #83376
Assignees
@narsaynorath
Labels
Product Area: Dashboards

Comments

@narsaynorath
Copy link
Member

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Open the widget builder
  2. Select Big Number
  3. Select Transactions dataset
  4. Change count to p75

Expected Result

Widget doesn't error

Actual Result

Widget errors saying cannot sort by a field that isn't selected. This is because we seem to add a sort when switching datasets as part of the reset process. We shouldn't be adding it for this display type.

Product Area

Dashboards

Link

No response

DSN

No response

Version

No response
@getsantry
Copy link
Contributor

getsantry bot commented Jan 13, 2025

Routing to @getsentry/product-owners-dashboards for triage ⏲️

@narsaynorath narsaynorath self-assigned this Jan 14, 2025
@narsaynorath narsaynorath mentioned this issue Jan 14, 2025
Merged
andrewshie-sentry pushed a commit that referenced this issue Jan 22, 2025
@narsaynorath @andrewshie-sentry
fix(widget-builder): Reset sort for big numbers on dataset change (#8…
f7eec2d 
…3376)

Big numbers don't support sorting, so adding the field breaks the flow
in this case because the user cannot remove it. The solution is to wipe
the sort when changing datasets

Closes #83328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narsaynorath narsaynorath

Labels
Product Area: Dashboards
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(widget-builder): Reset sort for big numbers on dataset change getsentry/sentry
1 participant
@narsaynorath