Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Replay x Web Vitals #69881

Closed
1 of 8 tasks
ryan953 opened this issue Apr 29, 2024 · 0 comments · Fixed by #76320
Closed
1 of 8 tasks

[Epic] Replay x Web Vitals #69881

ryan953 opened this issue Apr 29, 2024 · 0 comments · Fixed by #76320
Assignees
@c298lee

Comments

@ryan953
Copy link
Member

ryan953 commented Apr 29, 2024 •
edited by c298lee
Loading

Project Details; https://www.notion.so/sentry/Web-Vitals-x-Session-Replay-Discussion-f6cde2c7d54846749eefa83d4dd9882b
1st KTTR: https://www.notion.so/sentry/Replay-Web-Vitals-Breadcrumbs-0038416a37d8462793ad47a0cbce6ff2
2nd KTTR: https://www.notion.so/sentry/Replay-Web-Vitals-Insights-ff1230303b66485f9fac7441cc34ca46

@sentry/replay SDK - Capture Web Vitals
Beta Give feedback
  1. Add all Web Vitals to Replay Breadcrumbs sentry-javascript#11639
    5 of 6
    Feature: Performance Package: replay
    c298lee
  2. [Replay SDK] Add INP breadcrumb test sentry-javascript#12470
    Package: replay Type: Tests

Replay Details - Render Vitals as Breadcrumbs
Beta Give feedback

Replay List Page - show aggregate vitals
Beta Give feedback

Replay Details - New Vitals Tab/Panel
Beta Give feedback
This was referenced Jun 11, 2024
Draft
Closed
Merged
c298lee added a commit that referenced this issue Jun 20, 2024
@c298lee
feat(replay): Replay Web Vital Breadcrumbs (#72949)
f8cd519 
Enables replay web vital breadcrumbs if feature flag is on.
Example:
<img width="1480" alt="image"
src="https://github.com/getsentry/sentry/assets/55311782/6c2afeac-2655-4332-96ba-f16d498ee918">

Relates to #69881
@bruno-garcia bruno-garcia mentioned this issue Jul 25, 2024
Draft
2 tasks
@c298lee c298lee mentioned this issue Jul 29, 2024
Merged
c298lee added a commit to getsentry/sentry-javascript that referenced this issue Jul 30, 2024
@c298lee
ref(replay): Update CLS web vitals to align with browserTracing (#13058)
67a067a 
NodeId has been replaced with nodeIds which now accepts several nodes
since CLS scores are cumulative. Also updated CLS metrics to match CLS
captured from browserTracing.

Relates to getsentry/sentry#69881
@c298lee c298lee mentioned this issue Aug 14, 2024
Merged
@c298lee c298lee mentioned this issue Aug 28, 2024
Merged
c298lee added a commit to getsentry/sentry-javascript that referenced this issue Aug 28, 2024
@c298lee @billyvg
feat(replay): Add layout shift to CLS replay data (#13386)
918c011 
We want to show the score for each layout shift as well as the all the
nodes that contributed to the score, so we're adding a new
`attributions` object to our web vitals data

Relates to getsentry/sentry#69881

---------

Co-authored-by: Billy Vong <[email protected]>
@c298lee c298lee closed this as completed in ab2945b Sep 3, 2024
@c298lee c298lee mentioned this issue Sep 12, 2024
Merged
c298lee added a commit that referenced this issue Sep 12, 2024
@c298lee
fix(replay): CLS score is not in ms (#77397)
631e48a 
If the web vital is CLS, don't include `ms`. CLS is the only web vital
in replays that isn't measured in milliseconds.

Relates to #69881
This was referenced Sep 12, 2024
Merged
Closed
mifu67 pushed a commit that referenced this issue Sep 12, 2024
@c298lee @mifu67
fix(replay): CLS score is not in ms (#77397)
3a8b60b 
If the web vital is CLS, don't include `ms`. CLS is the only web vital
in replays that isn't measured in milliseconds.

Relates to #69881
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c298lee c298lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Web Vital Breadcrumb Design getsentry/sentry
2 participants
@ryan953 @c298lee