Replace called_with with assert_called_with

[tirkarthi]

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

called_with is an incorrect method that just returns a Mock object that evaluates to True and doesn't perform appropriate assertion. This method should be replaced with assert_called_with . Related CPython issue : python/cpython#100690

rg '\.called_with\(' -t py | grep -iv faux      
tests/sentry/auth/test_helper.py:        assert mock_auth.get_login_redirect.called_with(self.request)
tests/sentry/auth/test_helper.py:            assert mock_auth.get_login_redirect.called_with(self.request)
tests/sentry/auth/test_helper.py:        assert mock_messages.add_message.called_with(
tests/sentry/auth/test_helper.py:        assert mock_messages.add_message.called_with(
tests/sentry/tasks/test_derive_code_mappings.py:        assert logger.warning.called_with("The org has uninstalled the Sentry App.")
tests/sentry/tasks/test_derive_code_mappings.py:            assert logger.warning.called_with("derive_code_mappings.getting_lock_failed")
tests/sentry/tasks/test_post_process.py:        assert mock_derive_code_mappings.delay.called_with(self.project.id, data, False)
tests/sentry/tasks/test_post_process.py:        assert mock_derive_code_mappings.delay.called_with(self.project.id, data, True)
tests/sentry/integrations/utils/test_code_mapping.py:        assert logger.warning.called_with("More than one repo matched sentry/web/urls.py")
tests/sentry/integrations/github/test_integration.py:                assert logger.info.called_with(msg)
tests/sentry/integrations/github/test_integration.py:            assert logger.info.called_with("Using cached trees for Test-Organization.")
tests/sentry/notifications/utils/test_tasks.py:        assert mock_delay.called_with(

Expected Result

Use assert_called_with method

Actual Result

called_with method is used.

[getsantry]

Assigning to @getsentry/support for routing, due by Wed Jan 04 2023 01:00:00 GMT+0000. ⏲️

[getsantry]

Routing to @getsentry/team-web-sdk-backend for triage, due by Thu Jan 05 2023 01:00:00 GMT+0000. ⏲️

[getsantry]

Routing to @getsentry/app-backend for triage, due by Fri Jan 06 2023 01:00:00 GMT+0000. ⏲️

[JoshFerge]

@armenzg I've fixed some of these in #42799, but it looks like some recent tests have this issue and I wasn't able to fix them easily. mind taking a look? at:

tests/sentry/tasks/test_derive_code_mappings.py
tests/sentry/integrations/github/test_integration.py
tests/sentry/tasks/test_post_process.py

[armenzg]

Handling this in #43199