Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip-compile and CUSTOM_COMPILE_COMMAND #41303

Closed
atugushev opened this issue Nov 12, 2022 · 4 comments · Fixed by #41334
Closed

pip-compile and CUSTOM_COMPILE_COMMAND #41303

atugushev opened this issue Nov 12, 2022 · 4 comments · Fixed by #41334

Comments

@atugushev
Copy link
Contributor

atugushev commented Nov 12, 2022 •
edited
Loading

Environment

SaaS (https://sentry.io/)

Version

No response

Steps to Reproduce

JFYI

sentry/tools/freeze_requirements.py

Line 13 in 2e36d4d

# pip-compile doesn't let you customize the header, so we write

There is CUSTOM_COMPILE_COMMAND env to customize the header:

$ CUSTOM_COMPILE_COMMAND="make freeze-requirements" pip-compile
#
# This file is autogenerated by pip-compile with python 3.11
# To update, run:
#
#    make freeze-requirements
#
....

Expected Result

N/A

Actual Result

N/A
@asottile-sentry
Copy link
Member

@atugushev would you be interested in sending a quick patch?

@atugushev
Copy link
Contributor Author

@asottile-sentry sure, I'd love to. I'll open a PR then.

@getsentry-release
Copy link

Failed to route to Team: Dev Infrastructure. 😕

Defaulting to @getsentry/open-source for triage. ⏲️

@getsentry-release
Copy link

Routing to @getsentry/dev-infra for triage. ⏲️

@atugushev atugushev mentioned this issue Nov 14, 2022
Merged
asottile-sentry pushed a commit that referenced this issue Nov 14, 2022
@atugushev
Customize pip-compile header (#41334)
f6746b7 
Resolves #41303.

<!-- Describe your PR here. -->



<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Customize pip-compile header atugushev/sentry
5 participants
@chadwhitacre @atugushev @joshuarli @getsentry-release @asottile-sentry