Skip to content

Commit

Permalink
chore(profiling): Remove profiling-ga flag from frontend (#53360)
Browse files Browse the repository at this point in the history
Profiling has been in GA for a while now, time to remove the badges.
  • Loading branch information
Zylphrex authored Jul 21, 2023
1 parent 9fd943a commit 9e710e9
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 58 deletions.
2 changes: 0 additions & 2 deletions static/app/components/sidebar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,6 @@ function Sidebar({location, organization}: Props) {
label={t('Profiling')}
to={`/organizations/${organization.slug}/profiling/`}
id="profiling"
isBeta={!organization.features.includes('profiling-ga')}
isNew={organization.features.includes('profiling-ga')}
/>
</Feature>
);
Expand Down
5 changes: 0 additions & 5 deletions static/app/views/performance/transactionSummary/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,6 @@ function TransactionHeader({
hidden={!hasProfiling}
>
{t('Profiles')}
{organization.features.includes('profiling-ga') ? (
<FeatureBadge type="new" tooltipProps={{disabled: true}} />
) : (
<FeatureBadge type="beta" tooltipProps={{disabled: true}} />
)}
</TabList.Item>
</TabList>
);
Expand Down
82 changes: 31 additions & 51 deletions static/app/views/profiling/content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {Button} from 'sentry/components/button';
import DatePageFilter from 'sentry/components/datePageFilter';
import EnvironmentPageFilter from 'sentry/components/environmentPageFilter';
import SearchBar from 'sentry/components/events/searchBar';
import FeatureBadge from 'sentry/components/featureBadge';
import * as Layout from 'sentry/components/layouts/thirds';
import PageFilterBar from 'sentry/components/organizations/pageFilterBar';
import PageFiltersContainer from 'sentry/components/organizations/pageFilters/container';
Expand Down Expand Up @@ -153,8 +152,6 @@ function ProfilingContent({location}: ProfilingContentProps) {
return _eventView;
}, [location, query, selection.projects]);

const isProfilingGA = organization.features.includes('profiling-ga');

return (
<SentryDocumentTitle title={t('Profiling')} orgSlug={organization.slug}>
<PageFiltersContainer
Expand All @@ -165,7 +162,7 @@ function ProfilingContent({location}: ProfilingContentProps) {
}
>
<Layout.Page>
{isProfilingGA && <ProfilingBetaAlertBanner organization={organization} />}
<ProfilingBetaAlertBanner organization={organization} />
<Layout.Header>
<Layout.HeaderContent>
<Layout.Title>
Expand All @@ -176,11 +173,6 @@ function ProfilingContent({location}: ProfilingContentProps) {
'Profiling collects detailed information in production about the functions executing in your application and how long they take to run, giving you code-level visibility into your hot paths.'
)}
/>
{isProfilingGA ? (
<FeatureBadge type="new" />
) : (
<FeatureBadge type="beta" />
)}
</Layout.Title>
</Layout.HeaderContent>
</Layout.Header>
Expand Down Expand Up @@ -222,51 +214,39 @@ function ProfilingContent({location}: ProfilingContentProps) {
)}
</ActionBar>
{shouldShowProfilingOnboardingPanel ? (
isProfilingGA ? (
// If user is on m2, show default
<ProfilingOnboardingPanel
content={
<ProfilingAM1OrMMXUpgrade
organization={organization}
fallback={
<Fragment>
<h3>{t('Function level insights')}</h3>
<p>
{t(
'Discover slow-to-execute or resource intensive functions within your application'
)}
</p>
</Fragment>
}
/>
}
>
<ProfilingUpgradeButton
// If user is on m2, show default
<ProfilingOnboardingPanel
content={
<ProfilingAM1OrMMXUpgrade
organization={organization}
priority="primary"
fallback={
<Button onClick={onSetupProfilingClick} priority="primary">
{t('Set Up Profiling')}
</Button>
<Fragment>
<h3>{t('Function level insights')}</h3>
<p>
{t(
'Discover slow-to-execute or resource intensive functions within your application'
)}
</p>
</Fragment>
}
>
{t('Update plan')}
</ProfilingUpgradeButton>
<Button href="https://docs.sentry.io/product/profiling/" external>
{t('Read Docs')}
</Button>
</ProfilingOnboardingPanel>
) : (
// show previous state
<ProfilingOnboardingPanel>
<Button onClick={onSetupProfilingClick} priority="primary">
{t('Set Up Profiling')}
</Button>
<Button href="https://docs.sentry.io/product/profiling/" external>
{t('Read Docs')}
</Button>
</ProfilingOnboardingPanel>
)
/>
}
>
<ProfilingUpgradeButton
organization={organization}
priority="primary"
fallback={
<Button onClick={onSetupProfilingClick} priority="primary">
{t('Set Up Profiling')}
</Button>
}
>
{t('Update plan')}
</ProfilingUpgradeButton>
<Button href="https://docs.sentry.io/product/profiling/" external>
{t('Read Docs')}
</Button>
</ProfilingOnboardingPanel>
) : (
<Fragment>
{organization.features.includes(
Expand Down

0 comments on commit 9e710e9

Please sign in to comment.