fix(alerts): Use a real alert condition/action in tests (#57727)

getsentry · Oct 6, 2023 · 96b4403 · 96b4403
1 parent 4eadd39
commit 96b4403
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/fixtures/js-stubs/projectAlertRule.ts b/fixtures/js-stubs/projectAlertRule.ts
@@ -8,13 +8,15 @@ export function ProjectAlertRule(params: Partial<IssueAlertRule> = {}): IssueAle
     actionMatch: 'all',
     filterMatch: 'all',
     conditions: [
-      {name: 'An alert is first seen', id: 'sentry.rules.conditions.1', label: ''},
+      {
+        id: 'sentry.rules.conditions.first_seen_event.FirstSeenEventCondition',
+        name: 'A new issue is created',
+      },
     ],
     actions: [
       {
-        name: 'Send a notification to all services',
-        id: 'sentry.rules.actions.notify1',
-        label: '',
+        id: 'sentry.rules.actions.notify_event.NotifyEventAction',
+        name: 'Send a notification (for all legacy integrations)',
       },
     ],
     filters: [],

diff --git a/static/app/types/alerts.tsx b/static/app/types/alerts.tsx
@@ -78,15 +78,15 @@ export type IssueAlertRuleConditionTemplate = IssueAlertRuleActionTemplate;
  * These are the action or condition data that the user is editing or has saved.
  */
 export interface IssueAlertRuleAction
-  extends Omit<IssueAlertRuleActionTemplate, 'formFields' | 'enabled'> {
+  extends Omit<IssueAlertRuleActionTemplate, 'formFields' | 'enabled' | 'label'> {
   // These are the same values as the keys in `formFields` for a template
   [key: string]: any;
   dynamic_form_fields?: IssueConfigField[];
 }
 
 export type IssueAlertRuleCondition = Omit<
   IssueAlertRuleConditionTemplate,
-  'formFields' | 'enabled'
+  'formFields' | 'enabled' | 'label'
 > & {
   dynamic_form_fields?: IssueConfigField[];
 } & {