Skip to content

Commit

Permalink
ref: fix reassignment to release (Release vs str) (#75109)
Browse files Browse the repository at this point in the history
with models checked mypy's view of `release` went from `Any` to
`Release` causing a clobbering reassignment

<!-- Describe your PR here. -->
  • Loading branch information
asottile-sentry authored Jul 26, 2024
1 parent 84e405e commit 7774556
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3008,13 +3008,13 @@ def test_snuba_query_first_release_with_environments(self, mock_query: MagicMock
# give time for consumers to run and propogate changes to clickhouse
sleep(1)

for release, environment, expected_groups in (
for release_s, environment, expected_groups in (
(release.version, "development", [event.group.id]),
(release.version, "production", []),
):
response = self.get_success_response(
sort="new",
query=f"first_release:{release}",
query=f"first_release:{release_s}",
environment=environment,
)
assert len(response.data) == len(expected_groups)
Expand Down

0 comments on commit 7774556

Please sign in to comment.