Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(slack): Add Ignore Transaction Boundary in SDK Client for Tests (…
…#73582) The old SDK client had some logic to ignore transaction boundaries when using an RPC call to fetch the integration when running tests (the function doesn't do anything in production). https://github.com/getsentry/sentry/blob/master/src/sentry/incidents/serializers/alert_rule.py#L481-L488 This is required because in some parts of our code, we use the SDK Client within a transaction such as here: https://github.com/getsentry/sentry/blob/master/src/sentry/incidents/serializers/alert_rule.py#L481-L488 This is safe to do because the RPC call is a read operation. Without this function, we run into ``` E AssertionError: remote service method to /api/0/internal/rpc/integration/get_integration/ called inside transaction! Move service calls to outside of transactions. ``` when running tests that go through the above mentioned transaction code path.
- Loading branch information