Skip to content

Commit

Permalink
ref: pass event data instead of event (#72693)
Browse files Browse the repository at this point in the history
fixes some warnings here -- apparently these aren't tested -- will
follow up with strengthening the types and tests here

<!-- Describe your PR here. -->
  • Loading branch information
asottile-sentry authored Jun 13, 2024
1 parent f7fc4d2 commit 14004f8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/sentry/event_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def save(
job["in_grouping_transition"] = is_in_transition(project)
metric_tags = {
"platform": job["event"].platform or "unknown",
"sdk": normalized_sdk_tag_from_event(job["event"]),
"sdk": normalized_sdk_tag_from_event(job["event"].data),
"using_transition_optimization": job["optimized_grouping"],
"in_transition": job["in_grouping_transition"],
}
Expand Down Expand Up @@ -2629,7 +2629,7 @@ def discard_event(job: Job, attachments: Sequence[Attachment]) -> None:
skip_internal=True,
tags={
"platform": job["platform"],
"sdk": normalized_sdk_tag_from_event(job["event"]),
"sdk": normalized_sdk_tag_from_event(job["event"].data),
},
)

Expand Down Expand Up @@ -2931,7 +2931,7 @@ def _calculate_span_grouping(jobs: Sequence[Job], projects: ProjectsMapping) ->
amount=len(unique_default_hashes),
tags={
"platform": job["platform"] or "unknown",
"sdk": normalized_sdk_tag_from_event(event),
"sdk": normalized_sdk_tag_from_event(event.data),
},
)
except Exception:
Expand Down

0 comments on commit 14004f8

Please sign in to comment.