-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sentry initialization on Amazon Linux #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm still stuck on the problem conceptually: We can build sentry-native
statically using clang & libc++
. But the crashpad handler
that gets build alongside it has the libc++
dependency?
@bitsandfoxes Yes, the cc @supervacuus |
Everything you're building in this script has the Building any library statically does not mean the The difference is that this dependency is resolved for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to see this covered by some smoke test. I.e. run that amazon docker image in CI?
We should be able to add smoke tests once #658 is resolved. |
Currently
sentry-native
is built usingclang
andlibc++
to make the corresponding static libs included insentry-unreal
plugin compatible with UE. This introduces additional overhead for using Sentry on Linux sincelibc++
as one of theCrashpad
dependencies has to be installed separately and for some distros this package is not available (i.e. AL 2/2023).This PR suggests to build
sentry-native
in CI twice: once to obtain static libs using the current configuration and once to get theCrashpad
executable not dependent onlibc++
usinggcc
which then replaces binary obtained during the first build.Related #431
Closes #635