Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replay #1736

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: replay #1736

wants to merge 2 commits into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jul 24, 2024

A small experiment if we can get native replay working on mobile. Currently facing some issues:

Android

  1. proguard settings are not copied from android packages during build
  2. Unity 2019 has old kotlin version (we need 1.8.0), seems to work on Unity 2022
  3. The replay is sent but is just black screen, although, there are some breadcrumbs at least) - we'll either need to provide custom window/view to Android (not sure if that's possible) or implement a custom screenshot recorder, same as in Flutter
  4. There are native exceptions; maybe something to do with proguard
     2024/07/24 13:23:12.290 4984 5011 Error Sentry An exception occurred while processing replay event by processor: io.sentry.android.core.PerformanceAndroidEventProcessor
     2024/07/24 13:23:12.290 4984 5011 Error Sentry java.lang.AbstractMethodError: abstract method "io.sentry.SentryReplayEvent io.sentry.EventProcessor.process(io.sentry.SentryReplayEvent, io.sentry.Hint)"
     2024/07/24 13:23:12.290 4984 5011 Error Sentry 	at io.sentry.SentryClient.processReplayEvent(SentryClient.java:547)
     2024/07/24 13:23:12.290 4984 5011 Error Sentry 	at io.sentry.SentryClient.captureReplayEvent(SentryClient.java:300)
     2024/07/24 13:23:12.290 4984 5011 Error Sentry 	at io.sentry.Hub.captureReplay(Hub.java:965)
     2024/07/24 13:23:12.290 4984 5011 Error Sentry 	at io.sentry.HubAdapter.captureReplay(HubAdapter.java:274)
    

iOS

Currently can't test because I don't have a physical iPhone and Unity doesn't build for arm64 simulator. I've tried running on mac as if it was an iPad but replay didn't work - the integration got installed but there were no replays coming through.

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- replay ([#1736](https://github.com/getsentry/sentry-unity/pull/1736))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1f0d77e

Comment on lines +199 to +202
<ItemGroup>
<SentryJarArtifact Include="$(SentryAndroidRoot)/sentry/build/libs/sentry*.jar" />
</ItemGroup>
<Copy SourceFiles="@(SentryJarArtifact)" DestinationFiles="@(SentryJarArtifact->'$(SentryAndroidArtifactsDestination)sentry.jar')" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<exec> with cp didn't work on Windows

@bitsandfoxes
Copy link
Contributor

Unity 2019 has old kotlin version (we need 1.8.0), seems to work on Unity 2022

I'd say that's more than fine.

@bruno-garcia
Copy link
Member

Unity 2019 has old kotlin version (we need 1.8.0), seems to work on Unity 2022

I'd say that's more than fine.

Yeah if it worked only on the latest version it would also be OK IMO

@bruno-garcia
Copy link
Member

@vaind any chance to get this working on Unity 6 at least?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants