ci: update OS versions in mobile test matrix & fix flaky tests #1035
Conversation
vaind
force-pushed
the
ci/reenable-flaky-tests
branch
6 times, most recently
from
3d5ad93
to
3fc6ca4
Compare
vaind
changed the title
vaind
force-pushed
the
ci/reenable-flaky-tests
branch
7 times, most recently
from
3e6f292
to
78715c5
Compare
vaind
force-pushed
the
ci/reenable-flaky-tests
branch
from
78715c5
to
63caa38
Compare
| uses: reactivecircus/android-emulator-runner@76c2bf6f95ed6458fd659a1bdb680a0f8df232dc | ||
| id: smoke-test | ||
| timeout-minutes: 30 | ||
| continue-on-error: true |
There was a problem hiding this comment.
We will see it in the overview but it does not break CI?
There was a problem hiding this comment.
this is how it was before a recent PR - I've removed this line there and tried to implement a different logic. Didn't work. Putting it back.
| disk-size: 4096M # Some runs have out of storage error when installing the smoke test. | ||
| emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none | ||
| disable-animations: false | ||
| emulator-options: -no-snapshot-save -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none -accel on |
There was a problem hiding this comment.
-no-window is no longer necessary?
There was a problem hiding this comment.
not sure it ever was.
| if (Test-Path env:CI) | ||
| { | ||
| # Take Screenshot of VM to verify emulator start | ||
| screencapture "$(ArtifactsPath)/host-screenshot.jpg" | ||
| } |
There was a problem hiding this comment.
Was that not working because of the no-window?
There was a problem hiding this comment.
didn't even try without, as it means just having to wait for half an 75 minutes (at least) to see anything :D
| @@ -37,6 +38,7 @@ | |||
| class RequestVerifier: | |||
| __requests = [] | |||
| __testNumber = 0 | |||
| __lock = Lock() | |||
There was a problem hiding this comment.
it's using a multithreaded server (see end of script) and there was a data race causing the collected numbers to be off
| lock = Lock() | ||
|
|
||
|
|
||
| def registerUpload(name: str, chunks: int): |
There was a problem hiding this comment.
Does it make sense to change our "expected" count of debug symbols with a boolean to check if anything got uploaded at all? To get rid of those random changes?
There was a problem hiding this comment.
I wouldn't. I know it's not very convenient to update right now, but at least you know it's doesn't break completely (like uploading just some small bit, single chunk instead of 6, for example) by some change we do or a dependency update.
Co-authored-by: Stefan Jandl <[email protected]>
$ErrorActionPreference = "Stop"& fixes the previously silent errorsrecords Android CI sessions- this slows down CI and doesn't actually show anything useful. below is the code for backup:61e6a34(#1035)