Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add starfish v1 attributes to span data/breadcrumbs #756

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Add starfish v1 attributes to span data/breadcrumbs #756

merged 5 commits into from
Aug 29, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric self-assigned this Aug 29, 2023
@cleptric cleptric marked this pull request as ready for review August 29, 2023 11:14
AbhiPrasad
AbhiPrasad approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Michi

@cleptric cleptric merged commit b172a75 into master Aug 29, 2023
28 checks passed
@cleptric cleptric deleted the span-attributes branch August 29, 2023 13:07
@stephanie-anderson stephanie-anderson mentioned this pull request Sep 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@cleptric cleptric

Labels
Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleptric @AbhiPrasad