Allow settings tags directly on transactions/spans #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the only tags added to transactions are on the scope at the time of finish, but sometimes it is useful to have tags that aren't for the scope but just for the transaction
nrxus
force-pushed
the
sets-tags-on-transactions
branch
from
f30a9a9
to
55485cd
Compare
Swatinem
approved these changes
Oct 21, 2024
|
@Swatinem, thanks for the approval. Is there anything I need to do before it gets merged? |
|
Ah yes, this slipped my radar, as I don’t think anyone at the moment really maintains this repo/SDK actively. |
|
Thanks for the merge! If you are all okay with someone that doesn't work at sentry to help maintain (by reviewing/approving PRs) let me know. My team actively uses this crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the only tags added to transactions are the tags on the scope at the time you finish a transaction. Sometimes, however, it is useful to have tags that aren't for the scope but just for the transaction.
I am using the same signature as the equivalent method in
Scope.I know there are currently other PRs related to tags in transactions but I think those are more specific to the tracing integration so having methods to do it explicitly in a transaction (or span) is still useful.