sentry-core: make TransactionContext.trace_id readable

[tommilligan]

I would like to add the Sentry trace_id to our internal logs to be able to correlate it with the sentry transaction. Currently this isn't publicly accessible anywhere.

[kamilogorek]

This is already possible in JS SDK, so I don't see a reason why it shouldn't be here.

[tommilligan]

This is already possible in JS SDK, so I don't see a reason why it shouldn't be here.

Agreed, thanks. I already access trace_id as publicly accessible in the Python SDK, so figured it would be fine to have here too.

Note that this PR only exposes it on the TransactionContext, I think it could be exposed on Transaction as well, but that looked like a bit more effort/design required.

[kamilogorek]

Note that this PR only exposes it on the TransactionContext, I think it could be exposed on Transaction as well, but that looked like a bit more effort/design required.

cc @Swatinem

[Swatinem]

IMO its a good idea to also expose that on the Transaction, Span and TransactionOrSpan types.

[tommilligan]

IMO its a good idea to also expose that on the Transaction, Span and TransactionOrSpan types.

I'm happy to pick this up as a subsequent PR. The simplest option would be to expose the TraceContext using a getter, as I think everything on there is useful read-only information to the user. Is it acceptable to expose the inner protocol structs in that way?

sentry-rust/sentry-types/src/protocol/v7.rs

Line 1439 in 5013eb1

pub struct TraceContext {

Alternatively I could look at exposing the fields individually, which would be quite boilerplate heavy.

[tommilligan]

Opened a separate PR for exposing on the Transaction/Span types here: #534

[codecov]

Codecov Report

Merging #533 (4f50e57) into master (e7d5abf) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   69.69%   69.66%   -0.04%     
==========================================
  Files          66       66              
  Lines        6561     6564       +3     
==========================================
  Hits         4573     4573              
- Misses       1988     1991       +3     

[tommilligan]

Is there a scheduled release cadence for the sentry family of crates? Would like to know when a release with this in is likely to be cut

[Swatinem]

We don’t have a fixed cadence, rather adhoc. I triggered the automated release which needs to be approved and should be out shortly: getsentry/publish#1766

[tommilligan]

Amazing, thank you