feat: Support errors in tracing integration (NATIVE-310) #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will build an exception differently than event. It will look for two hardcoded keys in the "extras" of an event: 1. "error_kind" - this is optional and defaults to "Unknown" 2. "error" - this is optional and defaults to the event's message Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
refactor: reduce public api surface refactor: rename visitor type refactor: re-use parent context/transaction handling chore: reorder trait impl to match trait Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
Signed-off-by: Sean Pianka <[email protected]>
…to seanpianka-master
loewenheim
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #359 and merges it with the latest changes to the tracing integration.
It also adds another test for capturing
&dyn Errorviatracing::error!(), which this should all be about.