Fix bundle cache on CI #2432
Merged
Fix bundle cache on CI #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2432 +/- ##
==========================================
+ Coverage 98.66% 98.69% +0.02%
==========================================
Files 220 221 +1
Lines 14462 14508 +46
==========================================
+ Hits 14269 14318 +49
+ Misses 193 190 -3
|
solnic
force-pushed
the
solnic/fix-bundle-cache-on-ci
branch
from
f899c12
to
73c7046
Compare
st0012
reviewed
Oct 15, 2024
solnic
force-pushed
the
solnic/fix-bundle-cache-on-ci
branch
from
01459e9
to
c0ef31a
Compare
solnic
force-pushed
the
solnic/fix-bundle-cache-on-ci
branch
from
c0ef31a
to
e7c3ec4
Compare
st0012
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't set BUNDLE_GEMFILE correctly so caching bundles didn't work. This PR fixes it which should give us a significant speed bump when running this massive test suite.
#skip-changelog