Ignore Sidekiq::JobRetry::Handled exception #2337
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Sidekiq::JobRetry::Handled
exception to default Sidekiq ignore list.Sidekiq::JobRetry::Skip
exceptions are currently ignored, however, since Sidekiq 7.3.0 shipped, I thinkSidekiq::JobRetry::Handled
exceptions also need to be ignored.You can see the full diff between 7.2.4..7.3.0 and I'd particularly like to draw your attention to the changes within
lib/sidekiq/job_retry.rb
.You can see in certain scenarios Sidekiq now raises
Sidekiq::JobRetry::Handled
(7.3.0) instead ofSidekiq::JobRetry::Skip
(7.2.4).Without this change, some customers will see the following in their Sentry Issues after upgrading to Sidekiq 7.3.0.