feat: Log the component tree to all touch events, not just ones without a component with displayName. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Currently we only log the whole touch component tree when we couldn't find a component with a
displayNameset. This changes it so the component tree is logged every time:💡 Motivation and Context
This was done because we can't be sure which components have a
displayNameset. Any component from any library can have it set, looking at an example issue here: #950 where it looks like the user is using an Svg library where they have a component with thedisplayNameset toSvgand it doesn't log the user's component. It would be useful to just log the whole tree in the case that the touch event runs into a component with adisplayNamenot set by the user.💚 How did you test it?
Tested on sample app and verified on
sentry.iodashboard.📝 Checklist
🔮 Next steps