feat: Sync RN scope to native #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event.origin tag is added to the RN SDK Scope on init. On Android, we have a switch in the native beforeSend that determines where the event originated to set the tag. On iOS, the 'ios' tag is added in the native beforeSend if the event originated in the sentry-cocoa sdk Addresses #881
Native wrapper stringifies all values passed to setExtra.
bruno-garcia
reviewed
Jun 3, 2020
Split the stringify/serialize code block into _serializeObject helper.
Also works when just supplying unknown fields and none of the default ones.
jennmueng
changed the title
HazAT
requested changes
Jun 4, 2020
HazAT
approved these changes
Jun 4, 2020
|
I think this may have introduced some breaking changes- should the |
|
@cruzach Yes it does look like not checking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Fixes #694
📜 Description
Implemented a new class
ReactNativeScope extends Scopethat calls native scope setters equivalent methods on every call tosetUser,addBreadcrumb,setExtra,setExtras,setTag,setTags,setContext,clearBreadcrumbs.💡 Motivation and Context
Syncing the React Native scope to native events would allow users to actually group them together and see all the breadcrumbs from React Native that led to that event in native.
💚 How did you test it?
Created extensive scope assignment tests in the sample app.
📝 Checklist
🔮 Next steps