Add event tags so users can easily determine and filter where events originate from. #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event.origin tag is added to the RN SDK Scope on init. On Android, we have a switch in the native beforeSend that determines where the event originated to set the tag. On iOS, the 'ios' tag is added in the native beforeSend if the event originated in the sentry-cocoa sdk Addresses #881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Added a new tag
event.originto events with valuesjavascriptiosandroidAlong with an
event.environmenttag for native android events with values:javanativeThese tags are attached onto the event in the
beforeSendfunction in both iOS and Android and determined using the SDK name. On javascript, the event is added to the scope on init.💡 Motivation and Context
This change allows users to easily determine, search, and filter where the event originated in react native apps with native code running alongside javascript.
We use the simplified tag values above instead of the SDK names such as
sentry.java.androidorsentry.javascript.react-nativeas the goal is to make it easy to search and filter for the end-user.💚 How did you test it?
Tested using the sample app by testing all the options, and confirmed that the tags log correctly on the Sentry Test Dashboard. All existing tests are passing.
📝 Checklist
🔮 Next steps